Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TP-Editor] Adapt content-assist to support of version-ranges/no-version #1445

Merged
merged 2 commits into from
Oct 16, 2024
Merged

[TP-Editor] Adapt content-assist to support of version-ranges/no-version #1445

merged 2 commits into from
Oct 16, 2024

Conversation

HannesWell
Copy link
Member

@HannesWell HannesWell commented Oct 16, 2024 •
edited
Loading

  • Remove 'version' attribute from 'unit' proposal
    Now that PDE supports no versions in unit declarations it does not have to be proposed for all cases.

  • Skip units with version-range in the 'UpdateUnitVersions' action from the context menu in the Source tab.

Follow-up on #1245.

@eclipse-pde-bot
Copy link
Contributor

eclipse-pde-bot commented Oct 16, 2024 •
edited
Loading

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

ui/org.eclipse.pde.genericeditor.extension/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch 
From 7c77972de308e9ca91e39ca7af4cf97d90831347 Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <[email protected]>
Date: Wed, 16 Oct 2024 18:03:47 +0000
Subject: [PATCH] Version bump(s) for 4.34 stream


diff --git a/ui/org.eclipse.pde.genericeditor.extension/META-INF/MANIFEST.MF b/ui/org.eclipse.pde.genericeditor.extension/META-INF/MANIFEST.MF
index eb6d8b1050..121014c534 100644
--- a/ui/org.eclipse.pde.genericeditor.extension/META-INF/MANIFEST.MF
+++ b/ui/org.eclipse.pde.genericeditor.extension/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.pde.genericeditor.extension;singleton:=true
-Bundle-Version: 1.2.400.qualifier
+Bundle-Version: 1.2.500.qualifier
 Bundle-Localization: plugin
 Require-Bundle: org.eclipse.core.runtime,
  org.eclipse.jface.text,
-- 
2.46.2

Further information are available in Common Build Issues - Missing version increments.

@HannesWell
[TP-Editor] Adapt content-assist to support of version-ranges/no-version
d5a771f 
- Remove 'version' attribute from 'unit' proposal
Now that PDE supports no versions in unit declarations it does not have
to be proposed for all cases.

- Skip units with version-range in the 'UpdateUnitVersions' action from
the context menu in the Source tab.
@HannesWell HannesWell force-pushed the adapt-content-assist-to-version-ranges branch from 567e190 to d5a771f Compare October 16, 2024 18:00
@github-actions GitHub Actions
Copy link

Test Results

   285 files  ±0     285 suites  ±0   52m 11s ⏱️ - 1m 16s
 3 586 tests ±0   3 510 ✅ ±0   76 💤 ±0  0 ❌ ±0 
10 950 runs  ±0  10 719 ✅ ±0  231 💤 ±0  0 ❌ ±0 

Results for commit e02909d. ± Comparison against base commit 459a095.

@HannesWell HannesWell merged commit f6bcbe3 into eclipse-pde:master Oct 16, 2024
18 checks passed
@HannesWell HannesWell deleted the adapt-content-assist-to-version-ranges branch October 16, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HannesWell @eclipse-pde-bot